On Thu, Oct 17, 2013 at 05:02:00PM +0200, Denis Carikli wrote: > Cc: Rob Herring <[email protected]> > Cc: Pawel Moll <[email protected]> > Cc: Mark Rutland <[email protected]> > Cc: Stephen Warren <[email protected]> > Cc: Ian Campbell <[email protected]> > Cc: [email protected] > Cc: Vinod Koul <[email protected]> > Cc: Dan Williams <[email protected]> > Cc: Sascha Hauer <[email protected]> > Cc: [email protected] > Cc: Eric Bénard <[email protected]> > Signed-off-by: Denis Carikli <[email protected]> > --- > .../devicetree/bindings/dma/fsl-imx-ipu.txt | 53 > ++++++++++++++++++++ > drivers/dma/ipu/ipu_idmac.c | 8 +++ > 2 files changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/fsl-imx-ipu.txt > > diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-ipu.txt > b/Documentation/devicetree/bindings/dma/fsl-imx-ipu.txt > new file mode 100644 > index 0000000..a901c33 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/fsl-imx-ipu.txt > @@ -0,0 +1,53 @@ > +* Freescale Image Processing Unit DMA support for i.MX3x. > + > +This document will only describe differences to the generic DMA Controller > and > +DMA request bindings as described in dma/dma.txt . > + > +This dma driver supports the imx31 and imx35 devices. > + > +* DMA controller > + > +Required properties: > +- compatible : Should be "fsl,imx31-ipu". > +- reg : Should contain DMA registers location and length > +- interrupts : First item should be DMA interrupt, second one is optional and > + should contain DMA Error interrupt. > +- #dma-cells : Has to be 1. The ipu driver does not support anything else. > + > +Optional properties: > +- dma-channels : Number of DMA channels supported. Should be 32. > +- #dma-requests : Number of DMA requests supported. > + > +Example: > + > + ipu: ipu@53fc0000 { > + compatible = "fsl,imx31-ipu"; > + reg = < 0x53fc0000 0x5f > + 0x53fc0088 0x2b >; > + interrupts = <42 41>; > + dma-channels = <32>; > + #dma-cells = <1>; > + clocks = <&clks 55>; > + clock-names = ""; > + status = "disabled"; > + };
We already have a binding for the IPUv3. We shouldn't introduce a completely different binding for the IPUv1. We shouldn't expose the dma channels to dt and the lcdc should either be not exported to dt or be a subnode of the ipu node. The above binding is very close to what Linux has implemented, but not so close to the hardware. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
