On Tue, Oct 22, 2013 at 10:37:20AM -0500, Dinh Nguyen wrote: > Hi Mark, > > On 10/22/13 10:02 AM, Mark Rutland wrote: > >On Tue, Oct 22, 2013 at 03:38:47PM +0100, [email protected] wrote: > >>From: Dinh Nguyen <[email protected]> > >> > >>Add device tree support to the DW watchdog timer. > >> > >>Signed-off-by: Dinh Nguyen <[email protected]> > >>Acked-by: Jamie Iles <[email protected]> > >>Reviewed-by: Pavel Machek <[email protected]> > >>Cc: Guenter Roeck <[email protected]> > >>Cc: Jamie Iles <[email protected]> > >>Cc: Viresh Kumar <[email protected]> > >>Cc: Wim Van Sebroeck <[email protected]> > >>Cc: Pavel Machek <[email protected]> > >>Cc: Rob Herring <[email protected]> > >>Cc: Pawel Moll <[email protected]> > >>Cc: Mark Rutland <[email protected]> > >>Cc: Stephen Warren <[email protected]> > >>Cc: Ian Campbell <[email protected]> > >>Cc: [email protected] > >>Cc: [email protected] > >>--- > >>v5: > >>- Add documentation for clocks property > >>v4: > >>- Add interrupts as an optional property, use "should contain". > >>v3: > >>- Clean up documentation > >>v2: > >>- Use of_match_ptr() for of_match_table > >>--- > >> .../devicetree/bindings/watchdog/dw_wdt.txt | 20 > >> ++++++++++++++++++++ > >> drivers/watchdog/dw_wdt.c | 8 ++++++++ > >> 2 files changed, 28 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/watchdog/dw_wdt.txt > >> > >>diff --git a/Documentation/devicetree/bindings/watchdog/dw_wdt.txt > >>b/Documentation/devicetree/bindings/watchdog/dw_wdt.txt > >>new file mode 100644 > >>index 0000000..3af5c13 > >>--- /dev/null > >>+++ b/Documentation/devicetree/bindings/watchdog/dw_wdt.txt > >>@@ -0,0 +1,20 @@ > >>+Synopsys Designware Watchdog Timer > >>+ > >>+Required Properties: > >>+ > >>+- compatible : Should contain "snps,dw-wdt" > >>+- reg : Base address and size of the watchdog timer register. > >s/register/registers/ ? > > > >>+- clocks : phandle to the clock that drives the watchdog timer. > >Nit: clocks aren't necessarily described by just a phandle. > > > >How about: > > > >- clocks: phandle + clock-specifier for the clock that drives the watchdog > > timer. > > > >Otherwise, given previous comments this looks fine to me. > > > >Acked-by: Mark Rutland <[email protected]> > Fixed with above and added your Ack. So now the question is can take > this through the > arm-soc tree or through Wim Van Sebroeck's drivers/watchdog tree? > Guess that depends on Wim as the maintainer. There are other patches pending for the same driver, so it would be good if they are all merged through the same tree.
Can you send the final version of your patch so I can add it to my watchdog-next tree for tracking ? Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
