On Fri, Oct 25, 2013 at 08:50:40PM +0100, Grant Likely wrote: > On Wed, 23 Oct 2013 14:43:47 +0200, Denis Carikli <[email protected]> wrote: > > Cc: Jean-Christophe Plagniol-Villard <[email protected]> > > Cc: Tomi Valkeinen <[email protected]> > > Cc: [email protected] > > Cc: Rob Herring <[email protected]> > > Cc: Pawel Moll <[email protected]> > > Cc: Mark Rutland <[email protected]> > > Cc: Stephen Warren <[email protected]> > > Cc: Ian Campbell <[email protected]> > > Cc: [email protected] > > Cc: Sascha Hauer <[email protected]> > > Cc: [email protected] > > Cc: Eric Bénard <[email protected]> > > Signed-off-by: Denis Carikli <[email protected]> > > --- > > ChangeLog v2->v3: > > - The device tree bindings were reworked in order to make it look more like > > the > > IPUv3 bindings. > > - The interface_pix_fmt property now looks like the IPUv3 one. > > --- > > .../devicetree/bindings/video/fsl,mx3-fb.txt | 35 ++++++ > > drivers/video/Kconfig | 2 + > > drivers/video/mx3fb.c | 125 > > +++++++++++++++++--- > > 3 files changed, 147 insertions(+), 15 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/video/fsl,mx3-fb.txt > > > > diff --git a/Documentation/devicetree/bindings/video/fsl,mx3-fb.txt > > b/Documentation/devicetree/bindings/video/fsl,mx3-fb.txt > > new file mode 100644 > > index 0000000..0b31374 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/video/fsl,mx3-fb.txt > > @@ -0,0 +1,35 @@ > > +Freescale MX3 fb > > +================ > > + > > +Required properties: > > +- compatible: Should be "fsl,mx3fb". compatible chips include the imx31 > > and the > > + imx35. > > +- reg: should be register base and length as documented in the datasheet. > > +- clocks: Handle to the ipu_gate clock. > > + > > +Example: > > + > > +lcdc: mx3fb@53fc00b4 { > > + compatible = "fsl,mx3-fb"; > > + reg = <0x53fc00b4 0x0b>; > > + clocks = <&clks 55>; > > +}; > > This (and some of the other bindings) are trivial, and they are all > associated with a single SoC. I think it would be better to collect all > the mx3 bindings into a single file rather than distributing them all > over the bindings tree. > > I started thinking about this after some of the DT conversations in > Edinburgh this week. Unless there is a high likelyhood of components > being used separately, I think it is far more useful to collect all the > bindings for an SoC into a single file. It will certainly reduce a lot > of the boilerplate that we've been collecting in bindings documentation > files. > > A long time ago I took that approach for the mpc5200 documentation[1]. > Take a look at that organization and let me know what you think.
I don't think this is a good idea. When a new SoC comes out we don't know which components will be reused on the next SoC. This will cause a lot of bikeshedding when it actually is reused and then has to be moved. Also I would find it quite inconsistent if I had to lookup some devices in a SoC file and most bindings in subsystem specific files. So when searching for a binding I would first have to know if the hardware is unique to the SoC or not. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
