Hi Leela, On Thursday 07 of November 2013 17:21:18 Leela Krishna Amudala wrote: > The syscon regmap interface is used to configure AUTOMATIC_WDT_RESET_DISABLE > and MASK_WDT_RESET_REQUEST registers of PMU to mask/unmask enable/disable of > watchdog in probe and s2r scenarios. > > Signed-off-by: Leela Krishna Amudala <[email protected]> > --- > .../devicetree/bindings/watchdog/samsung-wdt.txt | 21 ++- > drivers/watchdog/s3c2410_wdt.c | 139 > ++++++++++++++++++-- > 2 files changed, 151 insertions(+), 9 deletions(-) [snip] > diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c > index 23aad7c..a151c20 100644 > --- a/drivers/watchdog/s3c2410_wdt.c > +++ b/drivers/watchdog/s3c2410_wdt.c [snip] > +/* s3c2410_get_wdt_driver_data */ > +static inline struct s3c2410_wdt_variant * > +get_wdt_drv_data(struct platform_device *pdev) > +{ > +#ifdef CONFIG_OF > + if (pdev->dev.of_node) { > + const struct of_device_id *match; > + match = of_match_node(s3c2410_wdt_match, pdev->dev.of_node); > + return (struct s3c2410_wdt_variant *)match->data; > + } > +#endif > + return (struct s3c2410_wdt_variant *) > + platform_get_device_id(pdev)->driver_data;
This code calls platform_get_device_id(), but I don't see any array of platform_device_id in this driver. This will always crash on a NULL pointer dereference whenever booted on a platform using board files. Also, as this driver is now using syscon API, its Kconfig entry should select MFD_SYSCON. Other than that, the patch looks fine. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
