On Nov 13, 2013, at 2:45 AM, Alexander Shiyan <[email protected]> wrote:
> This patch adds Device Tree support to the Microchip MCP251X driver. > > Signed-off-by: Alexander Shiyan <[email protected]> > --- > .../bindings/net/can/microchip,mcp251x.txt | 25 ++++++++++ > drivers/net/can/mcp251x.c | 57 ++++++++++++++++------ > 2 files changed, 66 insertions(+), 16 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/net/can/microchip,mcp251x.txt > > diff --git a/Documentation/devicetree/bindings/net/can/microchip,mcp251x.txt > b/Documentation/devicetree/bindings/net/can/microchip,mcp251x.txt > new file mode 100644 > index 0000000..06d95ee > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/can/microchip,mcp251x.txt > @@ -0,0 +1,25 @@ > +* Microchip MCP251X device tree bindings > + > +Registers a Microchip MCP251X stand-alone CAN controller connected to SPI > bus. “Register a” doesn’t seem like it should be in a binding spec. > + > +Required properties: > + - compatible: Should be one of the following: > + - "microchip,mcp2510" for MCP2510. > + - "microchip,mcp2515" for MCP2515. > + - reg: SPI chip select. > + - clocks: The clock feeding the CAN controller. > + - interrupt-parent: The parent interrupt controller. > + - interrupts: Should contain IRQ line for the CAN controller. > + > +Optional properties: > + - vdd-supply: Regulator that powers the CAN controller. > + - xceiver-supply: Regulator that powers the CAN transceiver. > + > +Example: > + can0: can@1 { > + compatible = "microchip,mcp2515"; > + reg = <1>; > + clocks = <&clk24m>; > + interrupt-parent = <&gpio4>; > + interrupts = <13 0x2>; Usually good to have example show all properties used (even optional ones) > + }; Other than the nits, binding looks good. - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
