On Wed, Dec 04, 2013 at 09:39:26PM +0200, Ivan Khoronzhuk wrote: > To reduce code duplicate and increase code readability use WDT core > code to handle WDT interface. > > Remove io_lock as the WDT core uses mutex to lock each wdt device. > Remove wdt_state as the WDT core tracks state with its own variable. > > The watchdog_init_timeout() can read timeout value from timeout-sec > property if the passed value is out of bounds. The heartbeat is > initialized in next way. If heartbeat is not set thought module > parameter, try to read it's value from WDT node timeout-sec property. > If node has no one, use default value. > > The heartbeat is hold in wdd->timeout by WDT core, so use it in > order to set timeout period. > > Acked-by: Santosh Shilimkar <[email protected]> > Reviewed-by: Guenter Roeck <[email protected]> > Signed-off-by: Ivan Khoronzhuk <[email protected]>
Looks good, except you did not explain ... > > - dev_info(dev, "heartbeat %d sec\n", heartbeat); > + watchdog_set_nowayout(wdd, 1); > why nowayout is enforced. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
