Hi Valentine, Thank you for the patch.
On Friday 17 January 2014 02:07:42 Valentine Barshak wrote: > Now that the clocks are available in the R-Car Gen2 DT, > add clocks property description to the sata_rcar bindings. > The clocks have been tested on r8a7791 so we use that > as an example of the R-Car SATA node. > > The patch is against for-next branch of the libata git repo. > > Signed-off-by: Valentine Barshak <[email protected]> > --- > Documentation/devicetree/bindings/ata/sata_rcar.txt | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ata/sata_rcar.txt > b/Documentation/devicetree/bindings/ata/sata_rcar.txt index > 1e61113..6da60c0 100644 > --- a/Documentation/devicetree/bindings/ata/sata_rcar.txt > +++ b/Documentation/devicetree/bindings/ata/sata_rcar.txt > @@ -7,12 +7,14 @@ Required properties: > - "renesas,sata-r8a7791" for R-Car M2 > - reg : address and length of the SATA registers; > - interrupts : must consist of one interrupt specifier. > +- clocks : must contain a phandle and clock-specifier pair. I would say "must contain a reference to the functional clock.", as the clock could be referenced by a phandle only depending on the SATA IP core integration in the SoC. Wouldn't it be time to have standard wordings for clocks (and interrupt) bindings ? > Example: > > -sata: sata@fc600000 { > - compatible = "renesas,sata-r8a7779"; > - reg = <0xfc600000 0x2000>; > +sata0: sata@ee300000 { > + compatible = "renesas,sata-r8a7791"; > + reg = <0 0xee300000 0 0x2000>; > interrupt-parent = <&gic>; > - interrupts = <0 100 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <0 105 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp8_clks R8A7791_CLK_SATA0>; > }; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
