On Tue, Jan 21, 2014 at 06:12:32AM -0300, Ezequiel Garcia wrote: > After adding the IRQ request, the BRIDGE_CAUSE bit should be cleared by the > bridge interrupt controller. There's no longer a need to do it in the watchdog > driver, so we can simply remove it.
When we talked about this before I pointed out that sequence here is important: - Disable WDT - Clear bridge - Enable WDT Looking at this patch in isolation it looks to me like the clear bridge lines should be replaced with a request_irq (as that does the clear) - is the request_irq in the wrong spot? > @@ -68,9 +66,6 @@ static int orion_wdt_start(struct watchdog_device *wdt_dev) > /* Set watchdog duration */ > writel(wdt_tclk * wdt_dev->timeout, wdt_reg + WDT_VAL); > > - /* Clear watchdog timer interrupt */ > - writel(~WDT_INT_REQ, BRIDGE_CAUSE); > - > /* Enable watchdog timer */ > atomic_io_modify(wdt_reg + TIMER_CTRL, WDT_EN, WDT_EN); > Regards, Jason -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
