On Sun, Jan 26, 2014 at 09:17:53AM +0100, Thomas Petazzoni wrote: [..] > > +/* > > + * The original devicetree binding for this driver specified only > > + * one memory resource, so in order to keep DT backwards compatibility > > + * we try to fallback to a hardcoded register address, if the resource > > + * is missing from the devicetree. > > + */ > > +static void __iomem *try_rstout_ioremap(struct platform_device *pdev, > > + phys_addr_t internal_regs) > > Why is it called "try" ? It actually does the mapping. So I would > prefer the function to be named: > > orion_wdt_ioremap_rstout() >
Ah, yes. This is a left over from the previous attempt. -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
