Hi Guenter,

On Tue, Jan 21, 2014 at 06:31:02AM -0800, Guenter Roeck wrote:
[..]
> > @@ -131,6 +138,19 @@ static int orion_wdt_probe(struct platform_device 
> > *pdev)
> >     if (!wdt_reg)
> >             return -ENOMEM;
> >
> > +   irq = platform_get_irq(pdev, 0);
> > +   if (irq > 0) {
> 
> 0 is a valid interrupt number, and platform_get_irq returns an error code on 
> errors.
> Should be >= 0.
> 

I'm revisiting this one. I believe this is not the hardware interrupt
number, but the one mapped into virq space. So, 0 is not a valid
interrupt number.

Right?
-- 
Ezequiel GarcĂ­a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to