> > ... then you'll still need this.
>
> Yes, I was far too vague..I'm going to stop explicitly populating the
> data field.
>
> static const struct of_device_id bcm59056_of_match[] = {
> { .compatible = "brcm,bcm59056"},
> { }
> };
+1
> > And I don't think you can drop this, as the I2C subsystem still
> > insists on it.
>
> Agreed. I'm just dropping explicit population of the driver_data field
> here.
>
> static const struct i2c_device_id bcm59056_i2c_id[] = {
> { "bcm59056" },
> { }
> };
+1
> > I think you need to keep this to supply the silly I2C ID table.
> >
> > I would just omit the '.data = (void *) VERSION' from the
> > of_match_table until you require it.
>
> Well, it's not even necessary for I2C ID table. the I2C subsystem is
> happy with just a matching entry on the i2c_device_id name field and
> NULL driver_data. palmas is implemented in this manner.
Guess what? +1 :)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
