Hi David, On Tue, Feb 04, 2014 at 08:24:13PM +0100, David Lanzendörfer wrote: > Hello > The following patchset adds support for the SD/MMC host found in the > Allwinner SoCs. > It contains all the necessary modifications for clock environment and also > the device > tree script modification which add it to all the boards using it. > The clock environment function needed for phase offset configuration has > been proposed and implemented by Emilio. > This patchset is the second attempt to send this driver upstream. > I'm looking forward to the acceptance of this patchset into mainline.
I have four comments here:
- Read Documentation/SubmittingPatches, especially Section 5 and 12
(hints, you forgot the clock maintainers for your clock patches
and you didn't put any signed-off-by tags)
- You ignored pretty much all the comments that were made during the
review of the first version. Go through
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-December/219339.html
and address the comments that were made.
- Each of your patches should compile. Fix the order of your
patches.
- Submit a v3, with the changes you made. Otherwise we have no way
of knowing what have been fixed and what didn't
Looking forward for the next iteration!
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
signature.asc
Description: Digital signature
