Hi Rahul,

The patch looks good, except one issue pointed inline.

On 14.02.2014 14:37, Rahul Sharma wrote:
diff --git a/arch/arm/boot/dts/exynos5260-xyref5260-evt0.dts 
b/arch/arm/boot/dts/exynos5260-xyref5260-evt0.dts
new file mode 100644
index 0000000..c4efc1e
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5260-xyref5260-evt0.dts

[snip]

+&mmc_0 {
+       status = "okay";
+       num-slots = <1>;
+       broken-cd;
+       bypass-smu;
+       supports-highspeed;
+       supports-hs200-mode; /* 200 Mhz */
+       fifo-depth = <0x40>;

This is a SoC-level property and it is already specified in your exynos5260.dtsi.

+       card-detect-delay = <200>;
+       samsung,dw-mshc-ciu-div = <3>;
+       samsung,dw-mshc-sdr-timing = <0 4>;
+       samsung,dw-mshc-ddr-timing = <0 2>;
+       pinctrl-names = "default";
+       pinctrl-0 = <&sd0_rdqs &sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8>;
+
+       slot@0 {
+               reg = <0>;
+               bus-width = <8>;
+       };
+};
+
+&mmc_2 {
+       status = "okay";
+       num-slots = <1>;
+       supports-highspeed;
+       fifo-depth = <0x40>;

Ditto.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to