On Sun, Feb 16, 2014 at 06:22:44PM +0400, Alexander Shiyan wrote: > Воскресенье, 16 февраля 2014, 22:03 +08:00 от Shawn Guo > <[email protected]>: > > For imx50-weim and imx6q-weim type of devices, there might a WEIM CS > > space configuration register in General Purpose Register controller, > > e.g. IOMUXC_GPR1 on i.MX6Q. > ... > > +static int __init imx_weim_gpr_setup(struct platform_device *pdev) > > +{ > > + struct device_node *np = pdev->dev.of_node; > > + struct property *prop; > > + const __be32 *p; > > + struct regmap *gpr; > > + u32 gprvals[4] = { > > + 05, /* CS0(128M) CS1(0M) CS2(0M) CS3(0M) */ > > + 033, /* CS0(64M) CS1(64M) CS2(0M) CS3(0M) */ > > + 0113, /* CS0(64M) CS1(32M) CS2(32M) CS3(0M) */ > > + 01111, /* CS0(64M) CS1(32M) CS2(32M) CS3(0M) */ > > + }; > > + u32 gprval = 0; > > + u32 val; > > + int cs = 0; > > + int i = 0; > > + > > + gpr = syscon_regmap_lookup_by_phandle(np, "fsl,weim-cs-gpr"); > > + if (IS_ERR(gpr)) { > > + dev_dbg(&pdev->dev, "failed to find weim-cs-gpr\n"); > > + return 0; > > Only one comment: > You do not use these error codes in the probe(), > so let's declare this function as void.
Oh, yes. I should check return of imx_weim_gpr_setup() in probe(). Will add in the next version. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
