On Tue, Feb 25, 2014 at 04:50:32PM -0500, Santosh Shilimkar wrote:
> From: Murali Karicheri <[email protected]>
> 
> This patch add compatibility strings for k2hk, k2l and k2e EVMs
> 
> Cc: Olof Johansson <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: Kumar Gala <[email protected]>
> Cc: Mark Rutland <[email protected]>
> Signed-off-by: Murali Karicheri <[email protected]>
> Signed-off-by: Santosh Shilimkar <[email protected]>
> ---
>  .../devicetree/bindings/arm/keystone/keystone.txt  |   10 ++++++++++
>  arch/arm/mach-keystone/keystone.c                  |    3 +++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/keystone/keystone.txt 
> b/Documentation/devicetree/bindings/arm/keystone/keystone.txt
> index 63c0e6a..ad16e7a 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/keystone.txt
> +++ b/Documentation/devicetree/bindings/arm/keystone/keystone.txt
> @@ -8,3 +8,13 @@ Required properties:
>   - compatible: All TI specific devices present in Keystone SOC should be in
>     the form "ti,keystone-*". Generic devices like gic, arch_timers, ns16550
>     type UART should use the specified compatible for those devices.
> +
> +Boards:
> +-  Keystone 2 Hawking/Kepler EVM
> +   compatible = "ti,k2hk-evm"
> +
> +-  Keystone 2 Lamarr EVM
> +   compatible = "ti,k2l-evm"

Your previous email said Lammar. One, or maybe both, are wrong, but which one?

> +
> +-  Keystone 2 Edison EVM
> +   compatible = "ti,k2e-evm"
> diff --git a/arch/arm/mach-keystone/keystone.c 
> b/arch/arm/mach-keystone/keystone.c
> index 6e6bb7d..aa0d212 100644
> --- a/arch/arm/mach-keystone/keystone.c
> +++ b/arch/arm/mach-keystone/keystone.c
> @@ -47,6 +47,9 @@ static void __init keystone_init(void)
>  
>  static const char *keystone_match[] __initconst = {
>       "ti,keystone-evm",
> +     "ti,k2hk-evm",
> +     "ti,k2l-evm",
> +     "ti,k2e-evm",

-evm indicate board-level compat fields. We'd be better off just keeping a
"ti,keystone" top-level compatible here and just using that to probe. That
way you don't have to touch the file for new boards in the future.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to