Hi Mike, On Mon, Mar 24, 2014 at 02:51:20PM -0700, Mike Turquette wrote: > Quoting Maxime Ripard (2014-03-13 08:14:13) > > Callers of clk_put must disable the clock first. This also means that as > > long > > as the clock is enabled the driver should hold a reference to that clock. > > Hence, the call to clk_put here are bogus and should be removed. > > > > Signed-off-by: Maxime Ripard <[email protected]> > > Looks good to me. There is a balanced clk_put in the module remove > function?
Actually, this is not part of any module, it's part of the function called through CLK_OF_DECLARE, so there's never a remove function for this code. -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
signature.asc
Description: Digital signature
