On Wed, Apr 16, 2014 at 12:49:27PM -0300, Ezequiel Garcia wrote: > On Apr 16, Jason Cooper wrote: > > On Wed, Apr 16, 2014 at 11:15:18AM -0300, Ezequiel Garcia wrote: > > > + /* This is only needed on A375 Z1 SoC silicon revision */ > > > + reg |= A375_Z1_WORKAROUND_BIT; > > > > and this seem to be the only differences between the two init functions. > > > > It also appears to be the only reason for having two data structs below. > > Is it worth checking for the compatible string in the init function so > > you only have one init and one data struct? > > > > Yes, thought about it at one point but I guess it seemed to me cleaner > this way. > > I'll squash it if you think keeping two structs is stupid bloat.
Well, it's really up to the thermal maintainer. Either way will work. I personally think it's easier to grok using the compatible string. Unfortunately, you're going to have the either check it twice, or set a variable. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
