Hi, Just trying to summarize what has been discussed so far in various threads regarding changes needed to this patch.
* Tomi Valkeinen <[email protected]> [140121 03:01]: > --- a/drivers/video/omap2/displays-new/panel-dpi.c > +++ b/drivers/video/omap2/displays-new/panel-dpi.c > @@ -182,6 +186,52 @@ static int panel_dpi_probe_pdata(struct platform_device > *pdev) > return 0; > } > > +static int panel_dpi_probe_of(struct platform_device *pdev) > +{ > + struct panel_drv_data *ddata = platform_get_drvdata(pdev); > + struct device_node *node = pdev->dev.of_node; > + struct omap_dss_device *in; > + int r; > + struct display_timing timing; > + struct videomode vm; > + int gpio; > + > + gpio = of_get_gpio(node, 0); > + if (gpio_is_valid(gpio) || gpio == -ENOENT) { > + ddata->enable_gpio = gpio; > + } else { > + dev_err(&pdev->dev, "failed to parse enable gpio\n"); > + return gpio; > + } We should set the GPIO polarity based on the OF_GPIO_ACTIVE_LOW like gpio_backlight_probe_dt is doing. Then do we really want to do the dev_err for each -EPROBE_DEFER here? > + gpio = of_get_gpio(node, 1); > + if (gpio_is_valid(gpio) || gpio == -ENOENT) { > + ddata->backlight_gpio = gpio; > + } else { > + dev_err(&pdev->dev, "failed to parse backlight gpio\n"); > + return gpio; > + } How about let's drop the backlight_gpio as discussed since it can be handled with gpio-backlight? Instead, let's add the panel specific reset_gpio as suggested by Joachim. That seems common to some dpi using panels. Then support for the other panel specific GPIOs can then be added as a follow-up patch when we know how we want to handle them. Oh, and this patch needs the related binding documentation too in Documentation/devicetree/bindings. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
