Hi, On Wed, Dec 18, 2013 at 02:43:18PM +0000, Sascha Hauer wrote: > Some rotary encoders have a stable state in all output state > combinations. Add support for this type of encoder. > > Signed-off-by: Sascha Hauer <[email protected]> > Cc: Dmitry Torokhov <[email protected]> > Cc: Daniel Mack <[email protected]> > Cc: [email protected] > Cc: [email protected] > --- > .../devicetree/bindings/input/rotary-encoder.txt | 1 + > Documentation/input/rotary-encoder.txt | 9 +++++-- > drivers/input/misc/rotary_encoder.c | 30 > ++++++++++++++++++++-- > include/linux/rotary_encoder.h | 1 + > 4 files changed, 37 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/input/rotary-encoder.txt > b/Documentation/devicetree/bindings/input/rotary-encoder.txt > index 3315495..cbdb29b 100644 > --- a/Documentation/devicetree/bindings/input/rotary-encoder.txt > +++ b/Documentation/devicetree/bindings/input/rotary-encoder.txt > @@ -15,6 +15,7 @@ Optional properties: > - rotary-encoder,rollover: Automatic rollove when the rotary value becomes > greater than the specified steps or smaller than 0. For absolute axis only. > - rotary-encoder,half-period: Makes the driver work on half-period mode. > +- rotary-encoder,quarter-period: Makes the driver work on quarter-period > mode.
The new property looks as sane to me as the half-period property, so for the binding addition: Acked-by: Mark Rutland <[email protected]> As a general nitpick it would be nicer if the binding didn't refer to the driver and had a description of {half,quarter} period modes inline, but that might be a bit tricky and shouldn't block this. Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
