On 14/05/14 00:26, Tony Lindgren wrote: > + /* lcd MO */ > + ddata->mo_gpio = sharp_ls_get_gpio_of(&pdev->dev, 0, 1, "mode"); > + if (PTR_ERR(ddata->mo_gpio) == -EPROBE_DEFER) > + return -EPROBE_DEFER; > + > + if (!IS_ERR(ddata->mo_gpio)) > + if (gpiod_get_raw_value_cansleep(ddata->mo_gpio)) > + ddata->flags |= SHARP_LS_QVGA;
Shouldn't there be an explicit flag in the DT data for this? If the
panel's MO pin is hardwired to, say, pull up, then the mode-gpios won't
have MO gpio, right? So something like:
mode-gpios = <0 /* high, lcd MO */
&gpio1 2 GPIO_ACTIVE_HIGH /* gpio2, lcd LR */
&gpio1 3 GPIO_ACTIVE_HIGH>; /* gpio3, lcd UD */
vga-mode; /* MO hardwired high */
Btw, the gpio.txt has each gpio inside <>:
chipsel-gpios = <&gpio1 12 0>,
<&gpio1 13 0>,
<0>, /* holes are permitted, means no GPIO 2 */
<&gpio2 2>;
Is that equivalent to having all gpios inside <>?
Tomi
signature.asc
Description: OpenPGP digital signature
