Hi Chanho, When testing some other patches with this series applied I found one more issue. Please see below.
On 02.05.2014 06:26, Chanho Park wrote: > This patch adds a PMU(Power Management Unit) syscon node. This > should be required for USB Phy syscon regmap I/F. > > Cc: Kamil Debski <[email protected]> > Signed-off-by: Chanho Park <[email protected]> > Reviewed-by: Tomasz Figa <[email protected]> > --- > Documentation/devicetree/bindings/arm/samsung/pmu.txt | 3 +++ > arch/arm/boot/dts/exynos4.dtsi | 5 +++++ > arch/arm/boot/dts/exynos4x12.dtsi | 4 ++++ > 3 files changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt > b/Documentation/devicetree/bindings/arm/samsung/pmu.txt > index f1f1552..b562634 100644 > --- a/Documentation/devicetree/bindings/arm/samsung/pmu.txt > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt > @@ -2,6 +2,9 @@ SAMSUNG Exynos SoC series PMU Registers > > Properties: > - compatible : should contain two values. First value must be one from > following list: > + - "samsung,exynos4210-pmu" - for Exynos4210 SoC, > + - "samsung,exynos4212-pmu" - for Exynos4212 SoC, > + - "samsung,exynos4412-pmu" - for Exynos4412 SoC, Here two compatible strings are specified, one for each SoC in 4x12 family, but... > - "samsung,exynos5250-pmu" - for Exynos5250 SoC, > - "samsung,exynos5420-pmu" - for Exynos5420 SoC. > second value must be always "syscon". > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index 2f8bcd0..264066f 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -110,6 +110,11 @@ > reg = <0x10010000 0x400>; > }; > > + pmu_system_controller: system-controller@10020000 { > + compatible = "samsung,exynos4210-pmu", "syscon"; > + reg = <0x10020000 0x4000>; > + }; > + > dsi_0: dsi@11C80000 { > compatible = "samsung,exynos4210-mipi-dsi"; > reg = <0x11C80000 0x10000>; > diff --git a/arch/arm/boot/dts/exynos4x12.dtsi > b/arch/arm/boot/dts/exynos4x12.dtsi > index c4a9306..7f767f7 100644 > --- a/arch/arm/boot/dts/exynos4x12.dtsi > +++ b/arch/arm/boot/dts/exynos4x12.dtsi > @@ -119,6 +119,10 @@ > interrupts = <0 72 0>; > }; > > + pmu_system_controller: system-controller@10020000 { > + compatible = "samsung,exynos4x12-pmu", "syscon"; Here one node is added for both using an undocumented compatible string. Please fix this according to documentation. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
