> -----Original Message-----
> From: [email protected] [mailto:iommu-
> [email protected]] On Behalf Of
> [email protected]
> Sent: Wednesday, May 21, 2014 9:28 AM
> To: Rickard Strandqvist; Joerg Roedel; Grant Likely
> Cc: [email protected]; [email protected]; Rob
> Herring; [email protected]
> Subject: RE: [PATCH] iommu: fsl_pamu.c: Fix for possible null pointer
> dereference
>
>
>
> > -----Original Message-----
> > From: [email protected] [mailto:iommu-
> > [email protected]] On Behalf Of Rickard Strandqvist
> > Sent: Saturday, May 17, 2014 10:47 PM
> > To: Joerg Roedel; Grant Likely
> > Cc: [email protected]; [email protected]; Rob
> > Herring; [email protected]; Rickard Strandqvist
> > Subject: [PATCH] iommu: fsl_pamu.c: Fix for possible null pointer
> > dereference
> >
> > There is otherwise a risk of a possible null pointer dereference.
>
> You are right.
[Sethi Varun-B16395] Thanks for pointing out the issue.
>
> >
> > Was largely found by using a static code analysis program called
> cppcheck.
> >
> > Signed-off-by: Rickard Strandqvist
> > <[email protected]>
>
> Reviewed-by: Bharat Bhushan <[email protected]>
Acknowledged-by: Varun Sethi <[email protected]>
> > ---
> > drivers/iommu/fsl_pamu.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c index
> > cba0498..b99dd88 100644
> > --- a/drivers/iommu/fsl_pamu.c
> > +++ b/drivers/iommu/fsl_pamu.c
> > @@ -592,8 +592,7 @@ found_cpu_node:
> > /* advance to next node in cache hierarchy */
> > node = of_find_node_by_phandle(*prop);
> > if (!node) {
> > - pr_debug("Invalid node for cache hierarchy %s\n",
> > - node->full_name);
> > + pr_debug("Invalid node for cache hierarchy\n");
> > return ~(u32)0;
> > }
> > }
> > --
> > 1.7.10.4
> >
> > _______________________________________________
> > iommu mailing list
> > [email protected]
> > https://lists.linuxfoundation.org/mailman/listinfo/iommu
> _______________________________________________
> iommu mailing list
> [email protected]
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
