RE: [PATCH] ARM: dts: move dp hpd gpio pin to pinctrl_0 for exynos5420 peach_pit

[Kukjin Kim]

Rahul Sharma wrote:
> 
> DP Hpd Gpio pin which is "gpx2-6" in Exynos 5420 based peach board,
> belongs to Pinctrl_0. It has moved to pinctrl_0 from pinctrl_3.
> 
> Signed-off-by: Rahul Sharma <rahul.sha...@samsung.com>
> ---
> Based on Kukjin's for-next branch.
> 
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> index d4127b0..29f64de 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -117,6 +117,13 @@
>               samsung,pin-pud = <1>;
>               samsung,pin-drv = <0>;
>       };
> +
> +     dp_hpd_gpio: dp_hpd_gpio {
> +             samsung,pins = "gpx2-6";
> +             samsung,pin-function = <0>;
> +             samsung,pin-pud = <3>;
> +             samsung,pin-drv = <0>;
> +     };
>  };
> 
>  &pinctrl_3 {
> @@ -133,13 +140,6 @@
>               samsung,pin-pud = <0>;
>               samsung,pin-drv = <0>;
>       };
> -
> -     dp_hpd_gpio: dp_hpd_gpio {
> -             samsung,pins = "gpx2-6";
> -             samsung,pin-function = <0>;
> -             samsung,pin-pud = <3>;
> -             samsung,pin-drv = <0>;
> -     };
>  };
> 
>  &rtc {
> --
> 1.7.9.5

Yeah, probably it happened when I applied your patch with rebase on top of
samsung-dt branch. Sorry about that.

BTW, I think alphabetical ordering would be nice like following...

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index d4127b0..79008ac 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -111,6 +111,13 @@
                samsung,pin-drv = <0>;
        };
 
+       dp_hpd_gpio: dp_hpd_gpio {
+               samsung,pins = "gpx2-6";
+               samsung,pin-function = <0>;
+               samsung,pin-pud = <3>;
+               samsung,pin-drv = <0>;
+       };
+
        hdmi_hpd_irq: hdmi-hpd-irq {
                samsung,pins = "gpx3-7";
                samsung,pin-function = <0>;
@@ -133,13 +140,6 @@
                samsung,pin-pud = <0>;
                samsung,pin-drv = <0>;
        };
-
-       dp_hpd_gpio: dp_hpd_gpio {
-               samsung,pins = "gpx2-6";
-               samsung,pin-function = <0>;
-               samsung,pin-pud = <3>;
-               samsung,pin-drv = <0>;
-       };
 };
 
 &rtc {


I will take this ;-)

Thanks,
Kukjin

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html