On Tue, May 27, 2014 at 08:28:52AM +0200, Andrzej Hajda wrote: > Hi Thierry, > > On 05/26/2014 03:41 PM, Thierry Reding wrote: > > On Wed, May 21, 2014 at 01:43:05PM +0900, YoungJun Cho wrote: > >> This patch adds DT bindings for s6e3fa0 panel. > >> The bindings describes panel resources, display timings and cpu mode > >> timings. > >> > >> Signed-off-by: YoungJun Cho <[email protected]> > >> Acked-by: Inki Dae <[email protected]> > >> Acked-by: Kyungmin Park <[email protected]> > >> --- > >> .../devicetree/bindings/panel/samsung,s6e3fa0.txt | 45 > >> ++++++++++++++++++++ > >> 1 file changed, 45 insertions(+) > >> create mode 100644 > >> Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt > > You're totally confusing me here. Half of this patch series is about > > adding i80 support to Exynos FIMD, and then you go and add what is > > apparently a DSI peripheral driver here that's supposed to be used by > > this new i80 support. Nothing I've been able to dig up indicates that > > i80 or DSI are in anyway related. > > FIMD can produce parallel RGB output or command mode in i80 style output > via parallel lines. > DSIM can accept parallel RGB stream in this case it produces MIPI DSI > video mode signal or it can accept i80 and in this case it translates it > to MIPI DSI command mode.
Then the command mode timings aren't a property of the panel at all. They describe what DSIM expects, so that's where they should be defined. Thierry
pgppywWSXBksz.pgp
Description: PGP signature
