Doug, On 25 June 2014 03:24, Doug Anderson <[email protected]> wrote: > Naveen, > > On Tue, Jun 24, 2014 at 5:19 AM, Naveen Krishna Chatradhi > <[email protected]> wrote: >> Exynos5420 based Peach PIT and Exynos5800 based PI boards have >> 4 NTC thermistors to measure temperatures at various points on the >> board. >> >> IIO based ADC becomes the parent and NTC thermistors are the childs, >> via the HWMON interface. >> >> Signed-off-by: Naveen Krishna Chatradhi <[email protected]> >> Cc: Doug Anderson <[email protected]> >> --- >> This patch needs >> 1. MAX77802 PMIC device tree nodes (for ldo9) >> https://www.mail-archive.com/[email protected]/msg31430.html >> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix >> >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 32 >> ++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) > > * You forgot: status="okay" for the ADC. One might question how this > patch was tested.
Will correct it. > > * Please also include this change for pi. MAX77802 device node was not added for Peach_PI (exynos5800-peach-pi.dts). I guess, Javier have a plan to send. I will edit the commit message to remove Peach_PI for now. Also, we have few similar nodes on Peach PI and Peach PIT. Any plans or discussion on merging the common nodes ? > > * We just got through the painful process of sorting this .dts file. > Please sort "&adc" alphabetically. Kukjin: please confirm that you > will keep an eye on patches and make sure that they are sorted OK. > > > Other than those problems this seems to work fine to me. > > -Doug Thanks for the Review. -- Shine bright, (: Nav :) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
