Hi Rickard, On 06/26/2014 01:32 PM, Rickard Strandqvist wrote: > Remove checking if a unsigned is less than zero > > This was found using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvist > <[email protected]>
You can add my: Acked-by: Maxime Coquelin <[email protected]> Thanks, Maxime > --- drivers/pinctrl/pinctrl-st.c | 2 +- 1 file changed, 1 > insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-st.c > b/drivers/pinctrl/pinctrl-st.c index 1bd6363bc9..f4ee1b1 100644 --- > a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c > @@ -1256,7 +1256,7 @@ static int st_pctl_parse_functions(struct > device_node *np, func = &info->functions[index]; func->name = > np->name; func->ngroups = of_get_child_count(np); - if > (func->ngroups <= 0) { + if (func->ngroups == 0) { > dev_err(info->dev, "No groups defined\n"); return -EINVAL; } > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
