> +     read_reg = readl(mc_vbase + DRAMADDRW);
> +
> +     width = readl(mc_vbase + DRAMIFWIDTH);
> +
> +     col = (read_reg & DRAMADDRW_COLBIT_MASK) >>
> +             DRAMADDRW_COLBIT_LSB;
> +     row = (read_reg & DRAMADDRW_ROWBIT_MASK) >>
> +             DRAMADDRW_ROWBIT_LSB;
> +     bank = (read_reg & DRAMADDRW_BANKBIT_MASK) >>
> +             DRAMADDRW_BANKBIT_LSB;
> +     cs = (read_reg & DRAMADDRW_CSBIT_MASK) >>
> +             DRAMADDRW_CSBIT_LSB;

As I said, all the defines only make this harder to read. The code is
pretty obvious if you put numbers in here...

Plus I'd like an explanation/comment of how the error injection works.

Thanks,
                                                                        Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to