Hi Arnd,
Thanks for reviewing, see my comments below: -
> > + if (priv->rst) {
> > + ret =
> > (priv->rst);
> > + if (ret)
> > + goto err_assert_power;
> > + }
>
> I wouldn't make these optional, just call the functions
> unconditionally and fail the probe function if they are
> not available.
>
> I'm not sure if it's worth keeping these functions in a
> common file. You are adding complexity this way and I don't
> think you are even saving a significant number of code lines
> compared to just having two copies of them.
I've unabstracted these common functions back into ehci-st.c and
ohci-st,c in V4.
regards,
Peter.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
