Hello, On Fri, Aug 08, 2014 at 12:07:42PM +0200, Julia Lawall wrote: > From: Julia Lawall <[email protected]> > > Of_node_put supports NULL as its argument, so the initial test is not > necessary. > > Suggested by Uwe Kleine-König. Thanks for picking up my suggestion.
> The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression e; > @@ > > -if (e) > of_node_put(e); > // </smpl> > I added [email protected] to Cc. Maybe they want to comment the series? If it's acceptable the logical next step is to add the patch to the collection of semantic patches, right? Best regards Uwe > Signed-off-by: Julia Lawall <[email protected]> > > --- > drivers/i2c/busses/i2c-mpc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c > index 6a32aa0..0edf630 100644 > --- a/drivers/i2c/busses/i2c-mpc.c > +++ b/drivers/i2c/busses/i2c-mpc.c > @@ -341,8 +341,7 @@ static u32 mpc_i2c_get_sec_cfg_8xxx(void) > iounmap(reg); > } > } > - if (node) > - of_node_put(node); > + of_node_put(node); > > return val; > } > > -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
