On Wed, 27 Aug 2014, Beniamino Galvani wrote:
> Ricoh RN5T618 is a power management IC which integrates 3 step-down
> DCDC converters, 7 low-dropout regulators, a Li-ion battery charger,
> fuel gauge, ADC, GPIOs and a watchdog timer.
>
> This commit adds a MFD core driver to support the I2C communication
> with the device.
>
> Signed-off-by: Beniamino Galvani <[email protected]>
> ---
> drivers/mfd/Kconfig | 11 +++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/rn5t618.c | 129 ++++++++++++++++++++++++++
> include/linux/mfd/rn5t618.h | 210
> +++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 351 insertions(+)
> create mode 100644 drivers/mfd/rn5t618.c
> create mode 100644 include/linux/mfd/rn5t618.h
Really nicely done. We don't normally get many first submissions at
this quality level.
One question and a _really_ small nit though.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 8d5fad2..fae8c5b 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -582,6 +582,17 @@ config MFD_RC5T583
> Additional drivers must be enabled in order to use the
> different functionality of the device.
>
> +config MFD_RN5T618
> + bool "Ricoh RN5T5618 PMIC"
Shouldn't this be tristate?
> + depends on I2C=y
If so, this should be:
depends on I2C
> + select MFD_CORE
> + select REGMAP_I2C
> + help
> + Say yes here to add support for the Ricoh RN5T618 PMIC. This
> + driver provides common support for accessing the device,
> + additional drivers must be enabled in order to use the
> + functionality of the device.
[...]
> +++ b/drivers/mfd/rn5t618.c
> @@ -0,0 +1,129 @@
[...]
> +static int rn5t618_i2c_probe(struct i2c_client *i2c,
> + const struct i2c_device_id *id)
> +{
[...]
> + dev_info(&i2c->dev, "RN5T618 MFD driver loaded");
Can you remove this line? We normally only print things when
information is gathered from a chip i.e. version information and the
like.
> + return 0;
> +}
[...]
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
