Hi Naveen,

Please see my comments inline.

On 27.08.2014 11:44, Naveen Krishna Chatradhi wrote:
> This patch adds initial dts file for the Espresso board
> based on Exynos7 from Samsung.

[snip]

> +     mmc@15740000 {

Please migrate this dts file to the reference-based syntax.

> +             status = "okay";
> +             num-slots = <1>;
> +             broken-cd;
> +             caps2-mmc-hs200-1_8v;
> +             supports-highspeed;
> +             non-removable;
> +             card-detect-delay = <200>;
> +             clock-frequency = <800000000>;
> +             samsung,dw-mshc-ciu-div = <3>;
> +             samsung,dw-mshc-sdr-timing = <0 4>;
> +             samsung,dw-mshc-ddr-timing = <0 2>;
> +             pinctrl-names = "default";
> +             pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_rdqs &sd0_bus1 &sd0_bus4 
> &sd0_bus8>;
> +             bus-width = <8>;
> +
> +             slot@0 {
> +                     reg = <0>;
> +                     bus-width = <8>;

Why is bus-width repeated?

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to