On Wed, Sep 03, 2014 at 09:18:42PM -0700, Doug Anderson wrote: > Chris, > > On Wed, Sep 3, 2014 at 6:12 PM, Chris Zhong <[email protected]> wrote: > > Adding RTC driver for supporting RTC device present inside RK808 PMIC. > > > > Signed-off-by: Chris Zhong <[email protected]> > > Signed-off-by: Zhang Qing <[email protected]> > > > > Tested-by: Heiko Stuebner <[email protected]> > > Reviewed-by: Doug Anderson <[email protected]> > Tested-by: Doug Anderson <[email protected]> > > > > + rk808_rtc->irq = platform_get_irq(pdev, 0); > > + if (rk808_rtc->irq < 0) { > > + dev_err(&pdev->dev, "Wake up is not possible as irq = %d\n", > > + rk808_rtc->irq); > > Technically you shouldn't print the error if it's -EPROBE_DEFER. > ...but I think that's really unlikely here (I can't imagine any real > cases where the interrupt parent for RK808 would actually be deferred) > so I won't push it.
Doug, platform_get_irq() simply iterates through IRQ resources assigned to the device, which are populated at platform device creation time. The only error it returns ever is -ENXIO, so we are fine here. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
