Jason, On Tue, Sep 09, 2014 at 12:29:58PM -0400, Jason Cooper wrote: > On Tue, Sep 09, 2014 at 04:44:05PM +0200, Antoine Tenart wrote: > > When changing the MAC address, in addition to updating the dev_addr in > > the net_device structure, this patch also update the MAC address > > registers (high and low) of the Ethernet controller with the new MAC. > > The address stored in these registers is used for IEEE 802.3x Ethernet > > flow control, which is already enabled. > > > > This patch also tries reading the MAC address stored in these registers > > when probing the driver, to use the MAC address set by the bootloader > > and avoid using a random one. > > Hmm, the wording here seems odd. I think the preference should be: > > 1) bootloader-supplied addr via DT > 2) addr read from device > 3) randomly generated one.
I agree. I'll update that. Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
