On Tue, 16 Sep 2014, Weike Chen wrote:
One more:
> +
> + /*
> + * Only port A can provide interrupts in all configurations of
> + * the IP.
> + */
> + if (pp->idx == 0 &&
> + of_property_read_bool(port_np, "interrupt-controller")) {
> + pp->irq = irq_of_parse_and_map(port_np, 0);
> + if (!pp->irq) {
> + dev_warn(dev, "no irq for bank %s\n",
> + port_np->full_name);
> + }
> + } else {
> + pp->irq = 0;
> + }
The else clause is not needed since pp->irq == 0 already, right?
Alan
> +
> + pp->irq_shared = false;
> + pp->gpio_base = -1;
> + pp->name = port_np->full_name;
> + }
> +
> + return pdata;
> +}
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
