On 16/10/2014 18:18, Fengguang Wu : > drivers/spi/spi-atmel.c:1518:1-4: WARNING: end returns can be simpified and > declaration on line 1514 can be dropped > > Simplify a trivial if-return sequence. Possibly combine with a > preceding function call. > Generated by: scripts/coccinelle/misc/simple_return.cocci > > CC: Wenyou Yang <[email protected]> > Signed-off-by: Fengguang Wu <[email protected]> > --- > > Please take the patch only if it's a positive warning. Thanks! > > spi-atmel.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c > @@ -1511,15 +1511,10 @@ static int atmel_spi_runtime_resume(stru > { > struct spi_master *master = dev_get_drvdata(dev); > struct atmel_spi *as = spi_master_get_devdata(master); > - int ret; > > pinctrl_pm_select_default_state(dev); > > - ret = clk_prepare_enable(as->clk); > - if (ret) > - return ret; > - > - return 0; > + return clk_prepare_enable(as->clk);
Indeed: Acked-by: Nicolas Ferre <[email protected]> > } > #endif > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
