On Tuesday 18 November 2014 14:59:54 Ankit Jindal wrote:
> On 17 November 2014 16:47, Arnd Bergmann <[email protected]> wrote:
> > On Monday 17 November 2014 16:06:11 Ankit Jindal wrote:
> >> +
> >> + qmtm1_uio: qmtm_uio@1f200000 {
> >> + compatible = "apm,xgene-qmtm";
> >> + status = "disabled";
> >> + reg = <0x0 0x1f200000 0x0 0x10000>,
> >> + <0x0 0x1b000000 0x0 0x400000>;
> >> + reg-names = "csr", "fabric";
> >> + qpool-memory = <&qmtm1_uio_qpool>;
> >> + clocks = <&qmtm1clk 0>;
> >> + num-queues = <0x400>;
> >> + devid = <1>;
> >> + };
> >> +
> >
> > To make my previous review comments clearer:
> >
> > NAK
> >
> > Do not create device nodes that are meant for a specific use case in
> > software and that are not usable for the common case. I don't think
> > it makes any sense to keep on submitting a UIO driver for this until
> > we have a proper network driver that uses this so we can make sure we
> > have a working binding.
>
> The dataplane frameworks like OpenDataPlane etc, need to have access
> to complete subsystem from the user space. Hence, we would like to
> have this driver and some other UIO drivers to be the part of kernel
> to have data plane frameworks working on our platform.
Please work with the people that do the in-kernel QMTM driver to come
up with a common binding then.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
