Hi Arnd, Thanks for you comments. Please see inline.
--Mayuresh. On Wed, Jan 7, 2015 at 2:00 PM, Arnd Bergmann <[email protected]> wrote: > On Wednesday 07 January 2015 10:58:55 Mayuresh Chitale wrote: >> +Required properties: >> +- compatible : >> + - "apm,xgene-pciedma" for pcie DMA on X-Gene SoC >> +- interrupts : An interrupt-specifier which is used to handle DMA interrupts >> + >> +Examples: >> + pciedma0 { >> + status = "disabled"; >> + compatible = "apm,xgene-pciedma"; >> + reg = < 0x0 0x1F2B0154 0x0 0xC >> + 0x0 0x1F2B0058 0x0 0x8>; >> + reg-names = "cfg", "intr"; >> + interrupts = <0x0 0xC6 0x4>; >> + }; >> > > The example contains a "reg-names" property that is neither listed > as optional nor mandatory, and that is not used by the driver. > Bettter drop that from the example. > > The 'reg' property is not documented in the binding. Please > document which register each index refers to. Ok. I will make those changes. > > Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
