In the function of_pci_get_host_bridge_resources() if the parsing of ranges fails, previously allocated resources inclusive of bus_range are not freed and are not expected to be freed by the function caller on error return.
This patch fixes the issues by adding code that properly frees resources and bus_range before exiting the function with an error return value. Cc: Arnd Bergmann <[email protected]> Cc: Liviu Dudau <[email protected]> Cc: Bjorn Helgaas <[email protected]> Cc: Rob Herring <[email protected]> Signed-off-by: Lorenzo Pieralisi <[email protected]> --- drivers/of/of_pci.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c index 88471d3..6fbfe99 100644 --- a/drivers/of/of_pci.c +++ b/drivers/of/of_pci.c @@ -146,6 +146,7 @@ int of_pci_get_host_bridge_resources(struct device_node *dev, struct of_pci_range_parser parser; char range_type[4]; int err; + struct pci_host_bridge_window *window; if (io_base) *io_base = (resource_size_t)OF_BAD_ADDR; @@ -225,7 +226,10 @@ int of_pci_get_host_bridge_resources(struct device_node *dev, conversion_failed: kfree(res); parse_failed: + list_for_each_entry(window, resources, list) + kfree(window->res); pci_free_resource_list(resources); + kfree(bus_range); return err; } EXPORT_SYMBOL_GPL(of_pci_get_host_bridge_resources); -- 2.2.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
