On Mon, Jan 12, 2015 at 11:13:11PM -0700, Christoph Junghans wrote:
> From: Christoph Junghans <[email protected]>
>
> The pogoplug differs from the SheevaPlug only by a
> few details, but especially in the led assignments.
> This patch was tested under Gentoo Linux and is
> based on dts files from Arch Linux ARM and OpenWrt.
>
> Suggested-by: Felix Kaechele <[email protected]>
> Suggested-by: Oleg Rakhmanov <[email protected]>
> Signed-off-by: Christoph Junghans <[email protected]>
> ---
>
> V1: initial patch
> V2: added GPL-2 header
> dropped earlyprintk from bootargs
> added stdout-path
> change leds name to scheme "devicename:colour:function"
> V3: rebase on v3.19-rc4
> fixed stdout-path to be &uart0
> fixed compiling issue by using pin-controller
Hi Christoph
Thanks for adding this list of changes.
> +
> + ocp@f1000000 {
> + pinctrl: pin-controller@10000 {
> + pmx_usb_power_enable: pmx-usb-power-enable {
> + marvell,pins = "mpp29";
> + marvell,function = "gpio";
> + };
> + pmx_led_green: pmx-led-green {
> + marvell,pins = "mpp48";
> + marvell,function = "gpio";
> + };
> + pmx_led_orange: pmx-led-orange {
> + marvell,pins = "mpp49";
> + marvell,function = "gpio";
> + };
> + };
Sorry, should of made myself more clear, when i pointed at:
https://lkml.org/lkml/2014/12/28/34
Please use the label for pinctl, and don't nest it under ocp@f1000000.
> + serial@12000 {
> + status = "ok";
> + };
> + };
Same here, just
&uart0 {
status = "okay";
};
Doing it like this is somewhat new, so most of the other kirkwood
boards don't do this. But we would like all new boards to use this
layout.
Thanks
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
