Le 14/01/2015 14:34, Boris Brezillon a écrit : > On Wed, 14 Jan 2015 14:21:47 +0100 > Nicolas Ferre <[email protected]> wrote: > >> Le 13/01/2015 19:46, Boris Brezillon a écrit : >>> These ids will be used to define irqs multiplexed on the first irq line. >>> >>> Signed-off-by: Boris Brezillon <[email protected]> >>> --- >>> .../dt-bindings/interrupt-controller/atmel-aic.h | 22 >>> ++++++++++++++++++++++ >>> 1 file changed, 22 insertions(+) >>> create mode 100644 include/dt-bindings/interrupt-controller/atmel-aic.h >>> >>> diff --git a/include/dt-bindings/interrupt-controller/atmel-aic.h >>> b/include/dt-bindings/interrupt-controller/atmel-aic.h >>> new file mode 100644 >>> index 0000000..e14a94f >>> --- /dev/null >>> +++ b/include/dt-bindings/interrupt-controller/atmel-aic.h >>> @@ -0,0 +1,22 @@ >>> +#ifndef _DT_BINDINGS_INTERRUPT_CONTROLLER_ARM_GIC_H >>> +#define _DT_BINDINGS_INTERRUPT_CONTROLLER_ARM_GIC_H >> >> Nit.: why ARM_GIC? > > Because I copied it from the arm-gic.h header and forgot to rename > those macros :-). > I'll fix that. > >> >>> +#include <dt-bindings/interrupt-controller/irq.h> >>> + >>> +#define AIC_IRQ1_PMC 0 >>> +#define AIC_IRQ1_ST 1 >>> +#define AIC_IRQ1_PIT 1 >>> +#define AIC_IRQ1_DBGU 2 >>> +#define AIC_IRQ1_RTC 3 >>> +#define AIC_IRQ1_RTT 4 >>> +#define AIC_IRQ1_WATCHDOG 5 >>> +#define AIC_IRQ1_MC 6 >>> +#define AIC_IRQ1_SDRAMC 6 >>> +#define AIC_IRQ1_DDRSDRC 6 >>> +#define AIC_IRQ1_RSTC 7 >>> +#define AIC_IRQ1_PMERRLOC 8 >>> +#define AIC_IRQ1_PMECC 9 > > Following up the discussion we had privately regarding these > macros (whether we really need them or not), maybe adding a comment > above the irqs property would be enough: > > dumb_irq1_demux: dumb-irq-demux@1 { > compatible = "irqchip-dumb-demux"; > interrupt-controller; > #interrupt-cells = <1>; > interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; > /* > * Interrupt lines: > * 0: PMC > * 1: PIT > * 2: DBGU > * 3: RTT > * 4: WATCHDOG > * 5: RSTC > */ > irqs = <0x3f>; > };
Well, I tend to prefer when no additional macros are defined in DT for no real added value. So, this comment seems to be enough... I would vote for this solution ;-) Thanks, bye, -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
