On Sun, 25 Jan 2015, Daniel Lezcano wrote:
> +static inline void rk_timer_set_mode(enum clock_event_mode mode,
> + struct clock_event_device *ce)
> +{
> + switch (mode) {
> + case CLOCK_EVT_MODE_PERIODIC:
> + rk_timer_disable(ce);
> + rk_timer_update_counter(rk_timer(ce)->freq / HZ - 1, ce);
> + rk_timer_enable(ce, TIMER_MODE_FREE_RUNNING);
Missing break. You disable the timer again right away ...
> + case CLOCK_EVT_MODE_ONESHOT:
> + case CLOCK_EVT_MODE_RESUME:
> + break;
> + case CLOCK_EVT_MODE_UNUSED:
> + case CLOCK_EVT_MODE_SHUTDOWN:
> + rk_timer_disable(ce);
> + break;
> + }
> +}
> +
> +static irqreturn_t rk_timer_interrupt(int irq, void *dev_id)
> +{
> + struct clock_event_device *ce = dev_id;
> +
> + rk_timer_interrupt_clear(ce);
> +
> + if (ce->mode == CLOCK_EVT_MODE_ONESHOT) {
> + rk_timer_disable(ce);
> + }
No need for the braces here.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
