On Tue 20 Jan 01:17 PST 2015, Stanimir Varbanov wrote: > From: Joonwoo Park <[email protected]> > > Add initial pinctrl driver to support pin configuration with > pinctrl framework for msm8916. > > Signed-off-by: Joonwoo Park <[email protected]> > Signed-off-by: Stanimir Varbanov <[email protected]> > --- [..] > + > +static const struct msm_pingroup msm8916_groups[] = { > + PINGROUP(0, blsp_spi1, blsp_uart1, blsp_uim1, dmic0_clk, NA, NA, NA, > NA, > + NA),
It's totally okay not to line break these things... > + PINGROUP(1, blsp_spi1, blsp_uart1, blsp_uim1, dmic0_data, NA, NA, NA, > + NA, NA), > + PINGROUP(2, blsp_spi1, blsp_uart1, blsp_i2c1, NA, NA, NA, NA, NA, NA), [..] > +}; > + [..] My documentation is lacking the pingroup table, the rest is: Reviewed-by: Bjorn Andersson <[email protected]> Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
