Hi Clement,
On Thu, Jan 22, 2015 at 04:27:38PM +0100, [email protected] wrote:
> @@ -686,7 +686,7 @@ L: [email protected] (moderated for
> non-subscribers)
> W: http://blackfin.uclinux.org/
> S: Supported
> F: sound/soc/blackfin/*
> -
> +
Unneeded change, please remove it.
> +config NFC_NXP_NCI
> + tristate "NXP-NCI NFC driver"
> + depends on NFC_NCI
> + default n
> + ---help---
> + Generic core driver for NXP NCI chips.
It usually is nice to be more specific and describe which chipsets
(e.g. NPC100) this driver supports among all the NXP NCI chipsets.
> +struct nxp_nci_phy_ops {
> + int (*enable)(void *id);
> + int (*fw_enable)(void *id);
Wouldn't a int (*enable)(void *id, enum nxp_nci_mode mode); hook be
enough ?
Cheers,
Samuel.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
