Hi Shimoda-san, On Tue, Apr 7, 2015 at 9:53 AM, Yoshihiro Shimoda <[email protected]> wrote: > This patch adds DMA properties to the HSUSB node.
Thank you for your patch! > Signed-off-by: Yoshihiro Shimoda <[email protected]> > --- > arch/arm/boot/dts/r8a7791.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi > index db3772e..5f20ad4 100644 > --- a/arch/arm/boot/dts/r8a7791.dtsi > +++ b/arch/arm/boot/dts/r8a7791.dtsi > @@ -722,6 +722,9 @@ > renesas,buswait = <4>; > phys = <&usb0 1>; > phy-names = "usb"; > + dmas = <&usb_dmac0 0>, <&usb_dmac0 1>, > + <&usb_dmac1 0>, <&usb_dmac1 1>; > + dma-names = "rx0", "tx1", "rx2", "tx3"; The numbering looks a bit strange, given the code looks up both tx and rx DMA channels for each channel index. Is it correct? The binding documentation (which lacks on example) states: - dma-names : Must contain a list of DMA names: - tx0 ... tx<n> - rx0 ... rx<n> - This <n> means DnFIFO in USBHS module. As there are 4 DnFIFOs, I'd expect tx0..tx3 and rx0..rx3. Can you please clarify? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
