On 04/08/2015 09:40 AM, Rob Herring wrote: > This doesn't sound right. It ignores failures because platform_get_irq > will parse the interrupts when called rather than just using the > resource struct and will return EPROBE_DEFER if the irq resource is > not ready. We left the of_device_alloc code in to be safe, but we > should be able to remove it.
This brings up a couple of points which are plaguing the serial drivers: 1. Is platform_get_irq() now required to properly obtain the mapped irq for DT-aware drivers? IOW, is platform_get_resource(IORESOURCE_IRQ) broken? Will it be if the of_device_alloc() code is removed? 2. Should DT-specific drivers not be using irq_of_parse_and_map()? On probe failure irq_dispose_mapping() will be junking the mapping, thus invalidating the irq assignment in the platform resource table, which breaks platform drivers which might otherwise probe successfully. Regards, Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
