On 13 July 2015 at 19:37, Josh Cartwright <[email protected]> wrote: > On Sat, Jul 11, 2015 at 07:28:49PM +0200, Joachim Eastwood wrote: >> Add driver for the RTC found on NXP LPC178x/18xx/408x/43xx devices. >> The RTC provides calendar and clock functionality together with >> alarm interrupt support. >> >> Signed-off-by: Joachim Eastwood <[email protected]> >> --- > [..] >> +static int lpc24xx_rtc_remove(struct platform_device *pdev) >> +{ >> + struct lpc24xx_rtc *rtc = platform_get_drvdata(pdev); >> + >> + /* Ensure all interrupt sources are masked */ >> + rtc_writel(rtc, LPC24XX_AMR, LPC24XX_ALARM_DISABLE); >> + rtc_writel(rtc, LPC24XX_CIIR, 0); >> + >> + rtc_writel(rtc, LPC24XX_CCR, LPC178X_CCALEN); >> + >> + clk_disable_unprepare(rtc->clk_rtc); >> + clk_disable_unprepare(rtc->clk_reg); >> + >> + return 0; >> +} >> + >> +static const struct of_device_id lpc24xx_rtc_match[] = { >> + { .compatible = "nxp,lpc1788-rtc" }, >> + { } >> +}; >> +MODULE_DEVICE_TABLE(of, lpc24xx_rtc_match); >> + >> +static struct platform_driver lpc24xx_rtc_driver = { >> + .probe = lpc24xx_rtc_probe, >> + .remove = lpc24xx_rtc_remove, >> + .driver = { >> + .name = "lpc24xx-rtc", >> + .of_match_table = lpc24xx_rtc_match, >> + }, >> +}; >> +module_platform_driver(lpc24xx_rtc_driver); >> + >> +MODULE_AUTHOR("Kevin Wells <[email protected]"); > > Missing closing '>'.
Ops. Well spotted. > Otherwise, > > Reviewed-by: Josh Cartwright <[email protected]> Thanks, Josh. I'll wait and see if Alexandre has any other comments before sending a new version. regards, Joachim Eastwood -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
