On Fri, 14 Aug 2015, Stephen Warren wrote:

> On 08/13/2015 05:05 PM, Eric Anholt wrote:
> > Signed-off-by: Eric Anholt <[email protected]>
> > Acked-by: Lee Jones <[email protected]>
> 
> A patch description might be nice, although admittedly the subject seems
> clear enough.

Agreed that the subject is clear enough on this occasion.

> > diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi 
> > b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> 
> > +           firmware_clocks: firmware-clocks {
> > +                   compatible = "raspberrypi,bcm2835-firmware-clocks";
> > +                   #clock-cells = <1>;
> > +                   raspberrypi,firmware = <&firmware>;
> > +           };
> 
> No need to resend for this, but just a background note: DT node names
> usually contain a device type not a device identity, so "clocks" not
> "firmware-clocks" would be typical.

Please fix this up when you re-send the set.

> This patch,
> Acked-by: Stephen Warren <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to