Hi Vincent, On Wed, Oct 21, 2015 at 08:54:07AM +0000, Vincent Cuissard wrote: > >> diff --git a/drivers/nfc/nfcmrvl/main.c b/drivers/nfc/nfcmrvl/main.c > >> index bd8db3d..1104fa3 100644 > >> --- a/drivers/nfc/nfcmrvl/main.c > >> +++ b/drivers/nfc/nfcmrvl/main.c > >> @@ -33,6 +33,9 @@ static int nfcmrvl_nci_open(struct nci_dev *ndev) > >> if (test_and_set_bit(NFCMRVL_NCI_RUNNING, &priv->flags)) > >> return 0; > >> > >> + /* Reset possible fault of previous session */ > >> + clear_bit(NFCMRVL_PHY_ERROR, &priv->flags); > >> + > > How is that related to this i2c driver ? > > i2c driver is currently the only deiver that needs to set this error. But in > the future other interfaces may need it too. That's why this clear code was > done in the main file to allow future code reuse. > Ok. I missed the fact that the i2c driver was actually setting this bit. Makes sense to me now.
Cheers, Samuel. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
