Hi Vincent, On Sat, Oct 24, 2015 at 12:15:28AM +0000, Vincent Cuissard wrote: > >>>> diff --git a/Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt > >>>> b/Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt > >>>> index 41058fc..0f95924 100644 > >>>> --- a/Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt > >>>> +++ b/Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt > >>>> @@ -2,9 +2,9 @@ > >>>> > >>>> Required properties: > >>>> - compatible: Should be: > >>>> - - "mrvl,nfc-uart" for UART devices > >>>> - - "mrvl,nfc-i2c" for I2C devices > >>>> - - "mrvl,nfc-spi" for SPI devices > >>>> + - "marvell,nfc-uart" for UART devices > >>>> + - "marvell,nfc-i2c" for I2C devices > >>>> + - "marvell,nfc-spi" for SPI devices > >>> > >>> There is no point in changing these and doing so breaks backwards > >>> compatibility. > >> > >> There is no break since these 2 drivers are new. In the same patchset I > >> first set mrvl and replace it to marvell since I figured out that this is > >> the name for all other Marvell drivers. > >> > > I agree the i2c and spi drivers are new, but not the uart one. > > That one should be supported in a backward compatible way. > > Since our chips are not sold through distributors yet I know that no one is > using this UART driver yet. > > That's why I changed this compatible string without any trouble. > > If you really want I can keep the compatibility here but it will just add > code that will never be used. > > As you wish. I consider a device tree binding as an ABI and I don't think there should be any exception for breaking a kernel ABI backward compatibility. Please keep this code in.
Cheers, Samuel. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
