On 26/11/2015 07:40, Martin Schiller wrote:
> On 11/25/2015 at 11:40 AM, Jonas Gorski wrote:
>> Hi
>>
>> On Wed, Nov 25, 2015 at 11:18 AM, Martin Schiller <[email protected]>
>> wrote:
>>> From: John Crispin <[email protected]>
>>>
>>> This patch is included in the openwrt patchset for several years now
>> and needs
>>> to go upstream as well. It includes the following changes:
>>> 1. Fix up inline function call to xway_mux_apply
>>
>> This really needs an explanation what is being fixed here.
>
> I hope John - as the original author of this patch - can explain
> why this change is necessary.
what change? why am I in Cc: and not To: if an action is required ?
John
>
>>
>>> 2. Fix GPIO Setup of GPIO Port3
>>
>> This change looks fine.
>>
>>> 3. Implement gpio_chip.to_irq
>>
>> These are three different changes (two fixes, one new feature) and
>> therefore should be split up into three patches.
>
> As I'm not the author of this patch, I decided to leave it as it is.
> But per se you are right, it would be better to split it up.
>
>>
>>> Signed-off-by: John Crispin <[email protected]>
>>> Signed-off-by: Martin Schiller <[email protected]>
>>> ---
>>
>> Also please provide a changelog for your patches here.
>
> OK.
>
>>
>>> drivers/pinctrl/pinctrl-xway.c | 28 ++++++++++++++++++++++++++--
>>> 1 file changed, 26 insertions(+), 2 deletions(-)
>>>
>>
>>
>> Jonas
>
> Martin
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
